feat: cannot extract files outside the target directory #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commits adds several security controls and tests so that files cannot be extracted outside of the target directory, and hardlinks cannot point to files outside of the target directory.
|
| }}, | ||
| }, | ||
| }, | ||
| error: `cannot extract from package "test-package": cannot create path /[a-z0-9\-\/]*/file outside of root /[a-z0-9\-\/]*`, |
There was a problem hiding this comment.
/[a-z0-9-/]*/file
What is this path? Is it to hide the root?
Comment on lines
+16
to
+17
| // Root defaults to "/" if empty. | ||
| Root string |
There was a problem hiding this comment.
Won't that be a bit risky to have / as the default? What if Chisel overwrites the files in the system?
How about /var/lib/chisel or $PWD? The snap may not be able to write to the former.
There was a problem hiding this comment.
This is the root of the filesystem, I am not sure we can provide a good default as users may choose whatever folder they wish. But, more importantly, I put the root as / because this is a general API and, in my opinion, the default shouldn't correspond to one use-case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits adds several security controls and tests so that files
cannot be extracted outside of the target directory, and hardlinks
cannot point to files outside of the target directory.