feature(inbound-template): refactor the inbound template #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathias-vandaele
force-pushed
the
973-update-the-template-projects
branch
from
8a4cbed to
0844a5f
Compare
johnBgood
reviewed
Jan 15, 2025
README.md
Outdated
| > | ||
| > Read more | ||
| > | ||
| about [creating Connectors](https://docs.camunda.io/docs/components/connectors/custom-built-connectors/connector-sdk/#creating-a-custom-connector) |
There was a problem hiding this comment.
I think your formatting breaks READMEs in general, you can deselected auto format in .md files.
This line should have a leading >
johnBgood
reviewed
Jan 15, 2025
README.md
Outdated
| > Read more | ||
| > | ||
| about [creating Connectors](https://docs.camunda.io/docs/components/connectors/custom-built-connectors/connector-sdk/#creating-a-custom-connector) | ||
| > | ||
| > Check out the [Connectors SDK](https://github.com/camunda/connector-sdk) |
There was a problem hiding this comment.
this link is outdated, we might use the new one
johnBgood
reviewed
Jan 15, 2025
README.md
Outdated
| that are used in other Connectors and the [Connector Runtime](https://github.com/camunda-community-hub/spring-zeebe/tree/master/connector-runtime#building-connector-runtime-bundles). | ||
| This helps to avoid classpath conflicts when the Connector is executed. | ||
| that are used in other Connectors and | ||
| the [Connector Runtime](https://github.com/camunda-community-hub/spring-zeebe/tree/master/connector-runtime#building-connector-runtime-bundles). |
johnBgood
reviewed
Jan 15, 2025
README.md
Outdated
|
|
||
| 1. Clone the Camunda Platform repository from GitHub: | ||
|
|
||
| ```shell |
There was a problem hiding this comment.
there should be no tab here, it breaks the MD
johnBgood
reviewed
Jan 15, 2025
README.md
Outdated
|
|
||
| In your IDE you can also simply navigate to the `LocalContainerRuntime` class in test scope and run it via your IDE. | ||
| If necessary, you can adjust `application.properties` in test scope. | ||
| ```shell |
There was a problem hiding this comment.
there should be no tab here, it breaks the MD
johnBgood
reviewed
Jan 15, 2025
README.md
Outdated
|
|
||
| 1. Run `io.camunda.example.LocalConnectorRuntime` to start your connector. | ||
| 2. Create and initiate a process that utilizes your newly created connector within the Camunda | ||
| Modeler.  |
There was a problem hiding this comment.
consider adding a new line here for readability
johnBgood
reviewed
Jan 15, 2025
|
|
||
| ### Test with SaaS | ||
|
|
||
| #### Prerequisites: |
There was a problem hiding this comment.
consider adding a new line here for readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Work on the refactoring of inbound template
Related issues
closes #https://github.com/camunda/team-connectors/issues/973