-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change sdk default for maxMessageSize #5300
Draft
eppdot
wants to merge
2
commits into
main
Choose a base branch
from
eppdot-increase-client-default-inbound-message-size
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more details check out the SDK PR camunda/camunda#29608
👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉 You can read more about the versioning within our docs in our documentation guidelines. |
2 tasks
github-merge-queue bot
pushed a commit
to camunda/camunda
that referenced
this pull request
Mar 20, 2025
…#29608) ## Description **This PR increases the default inbound message size limit to 5MB** We stumbled across an [issue](#29606) that made us think raising the limit on the client might be useful if the payload size approximation on the server is slightly off. Thus for the client it's still acceptable to process this slightly larger payload and not raise an error. ## Checklist <!--- Please delete options that are not relevant. Boxes should be checked by reviewer. --> - [x] update camunda-docs if needed (here is the docs [PR](camunda/camunda-docs#5300) 🕵️ ) - [x] enable backports [when recommended](https://github.com/camunda/camunda/wiki/CI-&-Automation#when-to-backport-ci-changes)
github-merge-queue bot
pushed a commit
to camunda/camunda
that referenced
this pull request
Mar 20, 2025
…#29608) ## Description **This PR increases the default inbound message size limit to 5MB** We stumbled across an [issue](#29606) that made us think raising the limit on the client might be useful if the payload size approximation on the server is slightly off. Thus for the client it's still acceptable to process this slightly larger payload and not raise an error. ## Checklist <!--- Please delete options that are not relevant. Boxes should be checked by reviewer. --> - [x] update camunda-docs if needed (here is the docs [PR](camunda/camunda-docs#5300) 🕵️ ) - [x] enable backports [when recommended](https://github.com/camunda/camunda/wiki/CI-&-Automation#when-to-backport-ci-changes)
github-merge-queue bot
pushed a commit
to camunda/camunda
that referenced
this pull request
Mar 20, 2025
…#29608) ## Description **This PR increases the default inbound message size limit to 5MB** We stumbled across an [issue](#29606) that made us think raising the limit on the client might be useful if the payload size approximation on the server is slightly off. Thus for the client it's still acceptable to process this slightly larger payload and not raise an error. ## Checklist <!--- Please delete options that are not relevant. Boxes should be checked by reviewer. --> - [x] update camunda-docs if needed (here is the docs [PR](camunda/camunda-docs#5300) 🕵️ ) - [x] enable backports [when recommended](https://github.com/camunda/camunda/wiki/CI-&-Automation#when-to-backport-ci-changes)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for more details check out the SDK PR
camunda/camunda#29608
Description
When should this change go live?
bug
orsupport
label)available & undocumented
label)hold
label)low prio
label)PR Checklist
/docs
directory (version 8.8)./versioned_docs/version-8.7/
directory (version 8.7)./versioned_docs
directory.@camunda/tech-writers
unless working with an embedded writer.