Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change sdk default for maxMessageSize #5300

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

eppdot
Copy link
Contributor

@eppdot eppdot commented Mar 19, 2025

for more details check out the SDK PR
camunda/camunda#29608

Description

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support. (add bug or support label)
  • This is already available but undocumented and should be released within a week. (add available & undocumented label)
  • This is on a specific schedule and the assignee will coordinate a release with the DevEx team. (create draft PR and/or add hold label)
  • This is part of a scheduled alpha or minor. (add alpha or minor label)
  • There is no urgency with this change (add low prio label)

PR Checklist

  • My changes are for an upcoming minor release and:
    • are in the /docs directory (version 8.8).
    • are in the /versioned_docs/version-8.7/ directory (version 8.7).
  • My changes are for an already released minor and are in a /versioned_docs directory.

@eppdot eppdot self-assigned this Mar 19, 2025
Copy link
Contributor

github-actions bot commented Mar 19, 2025

👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉

You can read more about the versioning within our docs in our documentation guidelines.

github-merge-queue bot pushed a commit to camunda/camunda that referenced this pull request Mar 20, 2025
…#29608)

## Description

**This PR increases the default  inbound message size limit to 5MB**

We stumbled across an
[issue](#29606) that made us
think raising the limit on the client might be useful if the payload
size approximation on the server is slightly off. Thus for the client
it's still acceptable to process this slightly larger payload and not
raise an error.

## Checklist

<!--- Please delete options that are not relevant. Boxes should be
checked by reviewer. -->
- [x] update camunda-docs if needed (here is the docs
[PR](camunda/camunda-docs#5300) 🕵️ )
- [x] enable backports [when
recommended](https://github.com/camunda/camunda/wiki/CI-&-Automation#when-to-backport-ci-changes)
github-merge-queue bot pushed a commit to camunda/camunda that referenced this pull request Mar 20, 2025
…#29608)

## Description

**This PR increases the default  inbound message size limit to 5MB**

We stumbled across an
[issue](#29606) that made us
think raising the limit on the client might be useful if the payload
size approximation on the server is slightly off. Thus for the client
it's still acceptable to process this slightly larger payload and not
raise an error.

## Checklist

<!--- Please delete options that are not relevant. Boxes should be
checked by reviewer. -->
- [x] update camunda-docs if needed (here is the docs
[PR](camunda/camunda-docs#5300) 🕵️ )
- [x] enable backports [when
recommended](https://github.com/camunda/camunda/wiki/CI-&-Automation#when-to-backport-ci-changes)
github-merge-queue bot pushed a commit to camunda/camunda that referenced this pull request Mar 20, 2025
…#29608)

## Description

**This PR increases the default  inbound message size limit to 5MB**

We stumbled across an
[issue](#29606) that made us
think raising the limit on the client might be useful if the payload
size approximation on the server is slightly off. Thus for the client
it's still acceptable to process this slightly larger payload and not
raise an error.

## Checklist

<!--- Please delete options that are not relevant. Boxes should be
checked by reviewer. -->
- [x] update camunda-docs if needed (here is the docs
[PR](camunda/camunda-docs#5300) 🕵️ )
- [x] enable backports [when
recommended](https://github.com/camunda/camunda/wiki/CI-&-Automation#when-to-backport-ci-changes)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant