-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add authorization and user management user guide #5282
Conversation
👋 🤖 🤔 Hello, @conceptualshark! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.6/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can do an editing pass over these, but my main question is whether or not this content will also apply in any way to (future) SaaS deployments?
If so we should probably move it out of the SM section and into Components, and make sure any content has this end state in mind.
It's a good point @conceptualshark, from my understanding this will apply also to SaaS. There is nothing related to the new Identity as far as I know in the SaaS documentation section |
@nicpuppa we don't need to document user management specifically for SaaS, because we will always use OIDC (=> Auth0) for that. But we need to document how to work with authorizations because they apply in both cases. |
What is the best approach here ? Move the authorization section outside the SM specific documentation ? Duplicate it in both ? I'm not sure @conceptualshark @ThorbenLindhauer |
In my opinion, once we have Identity-related documentation outside of the Self-Managed section, we're making an implicit agreement that any Identity guides could be found there. In an 8.8 world, I don't think SM users should have to go into the SM docs, which is largely for configuration and deployment, to find a user guide - I think that only works now because Identity doesn't exist in SaaS. I'd like to see both guides in Components, with a note where one doesn't apply to SaaS (and link to the eventual IdP guide, for example), but that's just a recommendation! I am also not sure if this means building out a new Identity component section in Components, or if Product has any plans for/input on placement here? @FarkasRabai |
Sounds meaningful to me. That makes it consistent with the docs structure for the other components and conceptually Identity is a webapp in the Orchestration Cluster like the other ones. |
I've pushed a version here that builds a section in the Component docs instead, just to see how it feels. I left the older content so we can just remove whichever we end up not using. I have a few questions that I don't think are quite relevant to the current state of Identity, but may impact how we want to position these docs overall:
It's not entirely clear for me yet how much SaaS will be aware of Identity, and which component will be handling these UI-based tasks. These likely don't all need addressing in this PR, but as we're addressing some structural docs changes, knowing the answers could help me better suggest an order. For ease, we could always merge these guides as in the initial proposal, and answer some of these questions separately. 🙂 |
@conceptualshark I like the new section, I think we can remove the duplicated section under SM. Related to your questions, I'm not sure if I'm able to answer, so I'll ping @Ben-Sheppard |
Hey @conceptualshark and @nicpuppa
It will change but honestly its difficult to say by how much (my expectation is greatly though), in SaaS there are three core flows that Management Identity is used for:
2 and 3 will now be cluster based, 1 will have to change also as authorizations are shifting to the cluster - I don't know what the flow looks like there.
If it is anything to do with the cluster (with the exception of client credentials for now) its Identity, if its organizational, its Console.
For now, this remains the same, we've had discussions about what this could look like in the future (configuring my cluster to talk to a specific IDP) but it will still be a Console level task IMO.
With 8.8 SaaS will be fully aware of Orchestration Identity, it will be a visible component that will offer the UI to handle the cluster management. As mentioned by @ThorbenLindhauer there I think are limited instances where a concept will only apply to SM and not SaaS (User management being one), but I would really like to remove that divide I think and just use a tag/note to say that User management is @ThorbenLindhauer regarding:
I was under the impression that we want to move away from the separated component approach is that not applicable/correct here? (Maybe something for @conceptualshark?) Does that help? (I'll also review the PR shortly) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its nice to see more content arriving for Identity! I've added some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small comment from my side.
It would be good to also get @conceptualshark to have a pass over the changes to make sure they align with his vision for the docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran through and made a few updates (and took the opportunity to add some Optimize references) - this is in good shape to me! 👍 We can come back and improve things (add SaaS references, etc), as those updates are made available.
🧹 Preview environment for this PR has been torn down. |
Description
This PR adds a user guide on how to create/delete an authorization and how to create/update/delete user
When should this change go live?
bug
orsupport
label)available & undocumented
label)hold
label)low prio
label)PR Checklist
/docs
directory (version 8.8)./versioned_docs/version-8.7/
directory (version 8.7)./versioned_docs
directory.@camunda/tech-writers
unless working with an embedded writer.closes #5281