-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add security notice 17 (Check Publication date before publishing) #5279
base: main
Are you sure you want to change the base?
Conversation
This should be released only with the next 8.6.x patch, whenever that is (at the latest first week of April). |
👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉 You can read more about the versioning within our docs in our documentation guidelines. |
There are failures which I'm confused by, like the format is because some utility is missing? 🤔 |
@npepinpe, I ran |
@pepopowitz can you have a look at
|
@akeller @pepopowitz that is because of the latest vale relase (3.10.0). Just ran into the same issue on a different PR and started looking whether anyone encountered / fixing it already. Fix is as easy as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@npepinpe I've reviewed and made some commits directly to the branch for readability, rewording etc. I just have a lingering question about some of the text which originally said:
it could lead to DoS issues both on the server side
I removed "both on", but wasn't sure if this was meant to be "both on the server and client side" perhaps?
Also, we don't have a ny solution/resolution/how to tell if affected info, not sure if that is by design?
Approved, with just these two questions that may or may not affect whether it is ready to publish (I don't think they are blocking). 🚀
No, that was not by design, sorry 🙈 |
Also, do we have a schedule for when this should be published, or a way of keeping in sync with the relevant 8.6.x patch? I.e., making sure we publish it at the right time. |
I was hoping you had a way to do that. So we release every month on the fist week a patch, but we might be releasing before that (since anyone from the monorepo can trigger a release). I'm not aware of anything, but I could imagine a step in our release process should handle that hopefully... |
I guess without some kind of automated notification, we'll have to rely on communication for now - to make sure we can publish the security notice in time - who would be best placed in the team for making sure we know perhaps 1 day ahead that the release will be going out please? Also, is this CVE fixed with the patch release - if so, shouldn't we mention it in this notice in a Solution section? |
Sorry, this is what happens from doing too many different things at once :( |
|
||
#### Publication date | ||
|
||
March 18th, 2025 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@npepinpe does this date need to be adjusted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I guess. What's the process if I don't know it? 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just leave it blank and wait until the release?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we know in advance the date, we can set it to that - my suggestion would be to change it to the date in the first week of the month (April) that this is planned for - is it on a Tuesday for example? If the date is simply really fluid/unpredictable, we're just going to have to rely on clear communication - I'll add something in the title/description to make sure this isn't missed.
Description
Adds a security notice for the following vulnerability: GHSA-735f-pc8j-v9w8
We've opted to release only on the next patch cycle, because:
When should this change go live?
bug
orsupport
label)available & undocumented
label)hold
label)low prio
label)PR Checklist
/docs
directory (version 8.8)./versioned_docs/version-8.7/
directory (version 8.7)./versioned_docs
directory.@camunda/tech-writers
unless working with an embedded writer.