Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Include cloud permissions in doc handling docs #5274

Merged
merged 4 commits into from
Mar 20, 2025

Conversation

georgios-goulos
Copy link
Contributor

@georgios-goulos georgios-goulos commented Mar 17, 2025

Description

This PR adds documentation around the permissions required by the API clients used by our application to manage documents when using GCP or AWS as storage.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support. (add bug or support label)
  • This is already available but undocumented and should be released within a week. (add available & undocumented label)
  • This is on a specific schedule and the assignee will coordinate a release with the DevEx team. (create draft PR and/or add hold label)
  • This is part of a scheduled alpha or minor. (add alpha or minor label)
  • There is no urgency with this change (add low prio label)

PR Checklist

  • My changes are for an upcoming minor release and:
    • are in the /docs directory (version 8.8).
    • are in the /versioned_docs/version-8.7/ directory (version 8.7).
  • My changes are for an already released minor and are in a /versioned_docs directory.

Relates to #5273

Copy link
Contributor

github-actions bot commented Mar 17, 2025

👋 🤖 🤔 Hello, @georgios-goulos! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.6/.

  • docs/components/concepts/document-handling.md
These files were changed only in versioned_docs/version-8.7/. You might want to duplicate these changes in versioned_docs/version-8.6/.
  • versioned_docs/version-8.7/components/concepts/document-handling.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@georgios-goulos georgios-goulos force-pushed the 5273-doc-handling-cloud-permissions branch from a48f569 to f27f612 Compare March 18, 2025 07:08
@georgios-goulos georgios-goulos added the target:8.7 Issues included in the 8.7 release label Mar 18, 2025
@georgios-goulos georgios-goulos marked this pull request as ready for review March 18, 2025 07:42
Copy link
Contributor

@christinaausley christinaausley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Just converted them into tables.

@georgios-goulos
Copy link
Contributor Author

Thanks @christinaausley! I had to add another permission for GCP (iam.serviceAccounts.signBlob).

@georgios-goulos georgios-goulos merged commit c5fa882 into main Mar 20, 2025
9 checks passed
@georgios-goulos georgios-goulos deleted the 5273-doc-handling-cloud-permissions branch March 20, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
target:8.7 Issues included in the 8.7 release
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants