feat: update prometheus rule to be more flexible #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omohammed95
force-pushed
the
ArgocdNotSynced-Alert
branch
from
3b089e7 to
cd90059
Compare
lentidas
requested changes
Jul 1, 2024
omohammed95
force-pushed
the
ArgocdNotSynced-Alert
branch
from
67ba0a1 to
3e9139b
Compare
omohammed95
force-pushed
the
ArgocdNotSynced-Alert
branch
from
04de985 to
8c96a8f
Compare
lentidas
requested changes
Aug 6, 2024
omohammed95
force-pushed
the
ArgocdNotSynced-Alert
branch
from
d192f6e to
3a4cd4a
Compare
lentidas
approved these changes
Aug 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
This PR updates the Prometheus rule for monitoring Argo CD applications' sync status. The current rule checks if there is exactly one application that is out of sync. This update replaces it with a more flexible rule that triggers when there is at least one out-of-sync application, while also ensuring the presence of the namespace label for better context in alerts.
Breaking change