fix: adjust the resources and remove default limits #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omohammed95
reviewed
Apr 4, 2024
We found that having limits by default on Argo CD could potentially break a bootstrap of clusters with a lot of Applications and/or ApplicationSets and then it was really difficult to increase the limits while Argo CD was hanging and starving for resources.
omohammed95
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
We found that having limits by default on Argo CD could potentially break a bootstrap of clusters with a lot of Applications and/or ApplicationSets and then it was really difficult to increase the limits while Argo CD was hanging and starving for resources.
Breaking change
Tests executed on which distribution(s)