fix: replace module interceptor with guarded require #871
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves error handling by wrapping webpack's
require
function with an error boundary, making it behave more similarly to Metro'sguardedLoadModule
and makes the error handling behaviour more consistent between the two.RuntimeGlobals.interceptModuleExecution
(which might prevent inlining modules)Final piece to #866
Additional context
This is roughly how body of
__webpack_require__
looks like:which matches with the equivalent function
loadModuleImplementation
inside of metro-runtime: https://github.com/facebook/metro/blob/76fd2186c129deac38023df9d4501b519ef9f011/packages/metro-runtime/src/polyfills/require.js#L403-L517loadModuleImplementation
is called withinguardedLoadModule
here:https://github.com/facebook/metro/blob/76fd2186c129deac38023df9d4501b519ef9f011/packages/metro-runtime/src/polyfills/require.js#L328-L347
guardedRequireRuntimeModule
is our equivalent ofguardedLoadModule
from metro-runtimeTest plan