Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: initalize compiler progress senders eagerly #574

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

jbroma
Copy link
Member

@jbroma jbroma commented Apr 22, 2024

Summary

sometimes Compiler workers send progress faster than anticipated, and the progress senders are not properly initialized. This results in compiler crashing and requires user to restart the dev server.

Test plan

  • - test locally on MacOS
  • - test locally on Windows

Copy link

changeset-bot bot commented Apr 22, 2024

🦋 Changeset detected

Latest commit: bfad5ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@callstack/repack Patch
@callstack/repack-dev-server Patch
@callstack/repack-init Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
repack-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2024 11:43am

@jbroma jbroma marked this pull request as ready for review April 22, 2024 17:26
Copy link
Member

@RafikiTiki RafikiTiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the one smol question LGTM

@jbroma jbroma merged commit bab94bf into main Apr 23, 2024
4 checks passed
@jbroma jbroma deleted the fix/eager-progress-senders branch April 23, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants