Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: try loading config through esm import first #1104

Merged
merged 2 commits into from
Mar 22, 2025
Merged

Conversation

jbroma
Copy link
Member

@jbroma jbroma commented Mar 22, 2025

Summary

Since require(esm) is a thing, our current method of loading projects with require first and then dynamic import fails - this PR changes this to support newer node versions by trying dynamic import first

Test plan

  • - testers work

Sorry, something went wrong.

jbroma added 2 commits March 22, 2025 16:57

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
Copy link

vercel bot commented Mar 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
repack-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 22, 2025 3:59pm

@jbroma jbroma merged commit eac08f2 into main Mar 22, 2025
5 checks passed
@jbroma jbroma deleted the fix/try-esm-first branch March 22, 2025 16:06
jbroma added a commit that referenced this pull request Mar 22, 2025
* fix: try loading config through esm import first

* chore: changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant