fix: add errors for queryBy* helpers when more instances found #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Esemesek
approved these changes
Nov 29, 2018
thymikee
added a commit
to brooksbecton/react-native-testing-library
that referenced
this pull request
Dec 11, 2018
* origin/master: chore: Update flow-bin to the latest version 🚀 (callstack#86) chore: Greenkeeper/@types/react 16.7.11 (callstack#82) chore: release 1.4.2 fix: add errors for queryBy* helpers when more instances found (callstack#79) chore: release 1.4.1 chore: release 1.4.1-es5.1 fix: remove deprecated existential Flow type and use any for now (callstack#77) docs: add note about new APIs in v1.4 (callstack#76) chore: Update flow-bin to the latest version 🚀 (callstack#75)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed all
queryByhelpers to throw when they find more than 1 instances.The previous behavior was buggy, because when more instances were found, it would still happily return
null, while user expected to find 0 instances.Test plan
Added a test.