Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: testOnly events #1741

Merged
merged 7 commits into from
Feb 5, 2025
Merged

feat: testOnly events #1741

merged 7 commits into from
Feb 5, 2025

Conversation

mdjastrzebski
Copy link
Member

@mdjastrzebski mdjastrzebski commented Jan 28, 2025

Summary

Resolves #1738

Provides support for testOnly_onXxx events to Fire Event and User Event, which together with software-mansion/react-native-gesture-handler#3357 allow for RNGH Pressable to work with RNTL.

Test plan

Addent automatic tests. Validate after RNGH PR is merged and published.

CC: @latekvo @sidferreira

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 95.23810% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.48%. Comparing base (315afca) to head (9ef72d5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/event-handler.ts 94.87% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1741      +/-   ##
==========================================
- Coverage   95.63%   95.48%   -0.15%     
==========================================
  Files          92       93       +1     
  Lines        5195     5205      +10     
  Branches      879      564     -315     
==========================================
+ Hits         4968     4970       +2     
- Misses        227      235       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdjastrzebski mdjastrzebski merged commit c47220b into main Feb 5, 2025
8 checks passed
@mdjastrzebski mdjastrzebski deleted the feat/testOnly_events branch February 5, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve react-native-gesture-handler::pressable handling
1 participant