Using dataset.apply with drop_remainder=True #125
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, although this modification seems fine, tfrecord_batcher.py has been depracated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Hi,
I sincerely appreciate all of your hard work. I noticed the following code while analyzing the code, which allows us to use a single API rather than using two APIs. This, in my opinion, will shorten the code and maybe improve performance. What do you think?
Issue ticket number and link
This is not an issue. This is a refactoring.
Type of change
(If applicable) How has this been tested?
I executed the test cases in the test folder to ensure that nothing was broken by the change. However, while attempting to determine the test coverage, I was puzzled by the outputs. But I think it was carried out well.