Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Wrong avatars shown in webhooks page #19386

Merged
merged 6 commits into from
Feb 24, 2025
Merged

fix: Wrong avatars shown in webhooks page #19386

merged 6 commits into from
Feb 24, 2025

Conversation

asadath1395
Copy link
Contributor

@asadath1395 asadath1395 commented Feb 19, 2025 •
edited
Loading

What does this PR do?

Fix wrong avatars shown in webhooks page

/claim #19372

image

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Create a new webhook as an admin for someone and team
  • Check the avatar is matching with appropriate user

@vercel Vercel
Copy link

vercel bot commented Feb 19, 2025

@asadath1395 is attempting to deploy a commit to the cal-staging Team on Vercel.

A member of the Team first needs to authorize it.

@algora-pbc algora-pbc bot mentioned this pull request Feb 19, 2025
Closed
@github-actions github-actions bot added ui area: UI, frontend, button, form, input workflows area: workflows, automations ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work 🐛 bug Something isn't working 💎 Bounty A bounty on Algora.io 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Feb 19, 2025
@dosubot dosubot bot added the webhooks area: webhooks, callback, webhook payload label Feb 19, 2025
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Feb 19, 2025
@graphite-app graphite-app bot requested a review from a team February 19, 2025 16:11
@graphite-app Graphite App
Copy link

graphite-app bot commented Feb 19, 2025 •
edited
Loading

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/19/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (02/19/25)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (02/24/25)

1 label was added to this PR based on Keith Williams's automation.

anikdhabal
anikdhabal approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@anikdhabal anikdhabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@anikdhabal anikdhabal enabled auto-merge (squash) February 24, 2025 07:42
@anikdhabal anikdhabal merged commit 2089ad4 into calcom:main Feb 24, 2025
32 of 36 checks passed
@github-actions GitHub Actions
Copy link
Contributor

E2E results are ready!

MuhammadAimanSulaiman pushed a commit to hit-pay/cal.com that referenced this pull request Feb 25, 2025
@asadath1395 @anikdhabal @MuhammadAimanSulaiman
fix: Wrong avatars shown in webhooks page (calcom#19386)
5b1efd5 
* fix: Wrong avatars shown in webhooks page

* Fix teams showing wrong avatar

* Fix type error

* Remove unused function arguments

---------

Co-authored-by: Anik Dhabal Babu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@retrogtx retrogtx retrogtx left review comments

@anikdhabal anikdhabal anikdhabal approved these changes

Assignees
No one assigned
Labels
🙋 Bounty claim 💎 Bounty A bounty on Algora.io 🐛 bug Something isn't working community Created by Linear-GitHub Sync 🧹 Improvements Improvements to existing features. Mostly UX/UI ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work ready-for-e2e ui area: UI, frontend, button, form, input webhooks area: webhooks, callback, webhook payload workflows area: workflows, automations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CAL-5186] /workflows: wrong avatars
3 participants
@asadath1395 @retrogtx @anikdhabal