feat: v2 routing forms responses endpoints #19319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithwillcode
added
core
…ons-routing-forms-responses
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
This reverts commit b641c06.
…ons-routing-forms-responses
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (02/18/25)1 reviewer was added to this PR based on Keith Williams's automation. |
E2E results are ready! |
supalarry
changed the title
|
|
||
| async getRoutingFormResponses(routingFormId: string) { | ||
| const responses = await this.routingFormsRepository.getRoutingFormResponses(routingFormId); | ||
| return this.routingFormsResponsesOutputService.getRoutingFormResponses(responses); |
There was a problem hiding this comment.
nit: They both have same name and very different purpose.
One fetches from DB and later parses it. Maybe we can call the later one, parseRoutingFormResponses or buildRoutingFormResponses
|
Codewise LGTM!! Don't have V2 setup locally so, didn't test it. Also, completely new endpoints and controllers so safe to go in general too. |
hariombalhara
approved these changes
Feb 20, 2025
…ons-routing-forms-responses
…ons-routing-forms-responses
…ons-routing-forms-responses
SomayChauhan
approved these changes
Feb 21, 2025
supalarry
deleted the
lauris/cal-5170-platform-feat-get-organizations-routing-forms-responses
branch
MuhammadAimanSulaiman
pushed a commit
to hit-pay/cal.com
that referenced
this pull request
Feb 25, 2025
* wip: routing forms responses * refactor structure * Revert "refactor structure" This reverts commit b641c06. * routing forms * remove unused file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linear CAL-5170