Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fixed tooltip position for routing form #19267

Merged
merged 8 commits into from
Feb 18, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/web/public/static/locales/en/common.json
Original file line number Diff line number Diff line change
Expand Up @@ -1993,7 +1993,7 @@
"delete_form_action": "Yes, delete Form",
"delete_form_confirmation": "Anyone who you've shared the link with will no longer be able to access it.",
"delete_form_confirmation_2": "All associated responses will be deleted.",
"typeform_redirect_url_copied": "Typeform Redirect URL copied! You can go and set the URL in Typeform form.",
"typeform_redirect_url_copied": "Redirect URL copied! You can go and set the URL in your own form.",
"modifications_in_fields_warning": "Modifications in fields and routes of following forms will be reflected in this form.",
"connected_forms": "Connected Forms",
"form_modifications_warning": "Following forms would be affected when you modify fields or routes here.",
Expand Down Expand Up @@ -2856,6 +2856,7 @@
"routing_form_insights_booking_status": "Booking Status",
"routing_form_insights_booking_at": "Booking At",
"routing_form_insights_submitted_at": "Submitted At",
"copy_redirect_url": "Copy Redirect URL",
"total_bookings_per_period": "Total Bookings per period",
"routed_to_per_period": "Routed to per period",
"per_day": "Per day",
Expand Down
10 changes: 6 additions & 4 deletions packages/app-store/routing-forms/components/SingleForm.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ const Actions = ({
<VerticalDivider />
</div>
<ButtonGroup combined containerProps={{ className: "hidden md:inline-flex items-center" }}>
<Tooltip content={t("preview")}>
<Tooltip sideOffset={4} content={t("preview")} side="bottom">
<FormAction
routingForm={form}
color="secondary"
Expand All @@ -100,9 +100,9 @@ const Actions = ({
type="button"
StartIcon="link"
tooltip={t("copy_link_to_form")}
tooltipSide="bottom"
/>

<Tooltip content={t("download_responses")}>
<Tooltip sideOffset={4} content={t("download_responses")} side="bottom">
<FormAction
data-testid="download-responses"
routingForm={form}
Expand All @@ -120,6 +120,7 @@ const Actions = ({
variant="icon"
StartIcon="code"
tooltip={t("embed")}
tooltipSide="bottom"
/>
<DropdownMenuSeparator />
<FormAction
Expand All @@ -131,6 +132,7 @@ const Actions = ({
color="secondary"
type="button"
tooltip={t("delete")}
tooltipSide="bottom"
/>
{typeformApp?.isInstalled ? (
<FormActionsDropdown>
Expand All @@ -141,7 +143,7 @@ const Actions = ({
color="minimal"
type="button"
StartIcon="link">
{t("Copy Typeform Redirect Url")}
{t("copy_redirect_url")}
</FormAction>
</FormActionsDropdown>
) : null}
Expand Down
Loading