fix: skip confirm step followup #19076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
keithwillcode
added
core
dosubot
bot
added
bookings
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (02/04/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add platform team as reviewer" took an action on this PR • (02/04/25)1 reviewer was added to this PR based on Keith Williams's automation. |
SomayChauhan
changed the title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
E2E results are ready! |
…Confirm" button should be hidden
Udit-takkar
reviewed
Feb 20, 2025
| return slotsForDates; | ||
|
|
||
| setSlotsPerDay(updatedSlots); | ||
| }, [JSON.stringify(dates), JSON.stringify(slots)]); |
There was a problem hiding this comment.
This could cause some performance issue if slots array is bug
There was a problem hiding this comment.
causing infinite re-render without it -- slots reference is changing
tried useMemo
Udit-takkar
previously approved these changes
Feb 20, 2025
|
Fixes - Verify Email Dialog Not Displaying When Skipping Confirmation - https://www.loom.com/share/9ccd703b79a6414287e0d294739bbd53?sid=ed676db9-b03b-4120-b7d1-b4eaed57924c |
…ping confirm step
Udit-takkar
requested changes
Feb 21, 2025
Udit-takkar
approved these changes
Feb 21, 2025
supalarry
approved these changes
Feb 21, 2025
MuhammadAimanSulaiman
pushed a commit
to hit-pay/cal.com
that referenced
this pull request
Feb 25, 2025
* Fix: Resolved double-click issue on timeSlot in Booker Atom * fix: show toast on booking error * fix: type error * Prevent the automatic change of bookerState when all fields are filled. * fix: when a user clicks on a new timeslot, any previously displayed "Confirm" button should be hidden * Update useSkipConfirmStep.ts * fix: remove 2 states for slots * Update useSlotsForDate.ts * fix types * use common types * fix: show VerifyCodeDialog and RedirectToInstantMeetingModal when skiping confirm step * fix for instant bookings --------- Co-authored-by: Udit Takkar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the following issues in the Booker flow when skipping the confirmation step:
Ensuring Users Are Notified of Submission Errors
Fixing the Double Click Issue on the Confirm Button
Before, users had to click the Confirm button twice in the Booker Atom for the submission to proceed.
This PR resolves the issue, ensuring a single click properly triggers the submission.
before: https://github.com/user-attachments/assets/d3d5909b-469b-4802-94be-5d0eac408ece
When a user clicks on a new timeslot, any previously displayed "Confirm" button should be hidden.
This ensures only one confirm button is visible at a time, improving clarity and avoiding confusion.
Clicking on a timeslot that already has the "Confirm" button visible should hide the button instead of confirming the booking.
This provides a more intuitive and user-friendly experience, aligning with natural user behavior. Since our "Confirm" button is large and clearly visible, it shouldn't be a problem
Mandatory Tasks (DO NOT REMOVE)