Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more automation #323

Merged
merged 3 commits into from
Nov 25, 2023
Merged

more automation #323

merged 3 commits into from
Nov 25, 2023

Conversation

hairyhenderson
Copy link
Contributor

@hairyhenderson hairyhenderson commented Oct 11, 2023 •
edited
Loading

One of the more manual parts of releasing was grabbing checksums and copy/pasting them into the stackbrew-config.yaml file. This PR automates that - the getChecksums.sh is essentially a script I had locally but never committed it.

@hairyhenderson
more automation
65fc7d0 
Signed-off-by: Dave Henderson <[email protected]>
@hairyhenderson
update gomplate install link
ece1c14 
Signed-off-by: Dave Henderson <[email protected]>
@francislavoie
Copy link
Member

  • Should we .gitignore the checksums.txt? I don't think we need to commit that.
  • Should maybe link directly to https://github.com/docker-library/official-images/blob/master/library/caddy in the README to save a couple clicks, I'd probably make a PR via GitHub UI ✏️ instead of checking out the official-images repo so a quick link is nice.
  • Maybe put make gen-dockerfiles in the README as the first step instead of just make to avoid the whole "toss away the library/caddy changes" part?
  • If it were me I'd maybe call them make gen and make lib or something shorter names, and make sure make lib doesn't also run gen-dokerfiles again redundantly 🤷‍♂️

@francislavoie francislavoie added documentation Improvements or additions to documentation enhancement New feature or request labels Oct 12, 2023
@hairyhenderson
Updates
34411c7 
Signed-off-by: Dave Henderson <[email protected]>
francislavoie
francislavoie approved these changes Nov 25, 2023
View reviewed changes
Copy link
Member

@francislavoie francislavoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome ☺️

@hairyhenderson hairyhenderson merged commit 9b1aa88 into master Nov 25, 2023
2 checks passed
@hairyhenderson hairyhenderson deleted the more-automation branch November 25, 2023 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francislavoie francislavoie francislavoie approved these changes

@mholt mholt Awaiting requested review from mholt

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hairyhenderson @francislavoie