ci: improve doc check #1454
Merged
ci: improve doc check #1454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandydoo
force-pushed
the
fix-doc-commit
branch
from
40c34b7
to
7229f83
Compare
sandydoo
force-pushed
the
fix-doc-commit
branch
from
65d72ed
to
e94eae0
Compare
sandydoo
force-pushed
the
fix-doc-commit
branch
3 times, most recently
from
4bd8018
to
b6f6f05
Compare
sandydoo
force-pushed
the
fix-doc-commit
branch
from
59e4612
to
0048279
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd probably need a PAT to let CI commit directly to forks. Instead, this will will run doc gen on push, letting it run in the forked repos. The PR check will print out an error on the run if the docs need to be committed.
All of this might end up too high friction for contributors merging from forks. Let's see how it goes.