Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli test should use local devenv module #1432

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ento
Copy link

@ento ento commented Sep 9, 2024

One change from #1421 that wasn't part of #1427. (Both PRs addressed the same bug in devenv container build shell, and the latter was merged.)

While working on #1421, I noticed tests/cli, which runs devenv container build shell as part of its test script, wouldn't fail as it should've when the bug was present. I believe it's because tests/cli/devenv.yaml doesn't override the devenv input like devenv-run-tests or tests/clean/devenv.yaml does.

// Override the input for the devenv module
config.add_input(
"devenv",
&format!("path:{:}?dir=src/modules", cwd.to_str().unwrap()),
&[],
);

inputs:
devenv:
url: path:../../?dir=src/modules

@domenkozar
Copy link
Member

Thanks for catching this one! I wonder if there's a better design to make sure devenv cli always uses the override in all commands.

@domenkozar
Copy link
Member

I'm going to let @sandydoo chip in next week if we could expose devenv on $PATH with correct devenv input override.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants