Update templates .envrc files #1428
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update templates .envrc files to use watch_file instead of the deprecated nix_direnv_watch_file.
thenonameguy
reviewed
Sep 7, 2024
templates/flake-parts/.envrc
Outdated
| @@ -2,8 +2,8 @@ if ! has nix_direnv_version || ! nix_direnv_version 2.2.1; then | |||
| source_url "https://raw.githubusercontent.com/nix-community/nix-direnv/2.2.1/direnvrc" "sha256-zelF0vLbEl5uaqrfIzbgNzJWGmLzCmYAkInj/LNxvKs=" | |||
There was a problem hiding this comment.
With this current direnvrc direnv extension, this breaks the nix_watches extra functionality, as devenv doesn't use https://github.com/nix-community/nix-direnv directly.
There was a problem hiding this comment.
Okay, I bumped the version to 2.5.0 as that's the version that nix_direnv_watch_file was originally deprecated in. Sorry for the inconvenience, I'm not familiar with the more advanced usage of direnv.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update flake templates' .envrc files to use watch_file
instead of the deprecated nix_direnv_watch_file.