Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metrics components to frontend #246

Merged
merged 5 commits into from
Feb 24, 2025
Merged

Conversation

sconnole
Copy link
Contributor

The original PR has stalled #58 and I would like to be able to use metrics in my cachet application. This is more recently rebased from main than the original PR

here the metrics chart rendering (which is all that I need for my application)
image

Happy to make updates as requested. @jbrooksuk

using chartjs to render the chart
@jbrooksuk
Copy link
Member

Great start on this, @sconnole. There are a few things we need to sort before we can merge:

  1. Please don't commit the compiled files, these will be generated automatically once merged.
  2. The chart text isn't visible in light mode. I tried a quick pass at supporting light / dark mode with CSS variables and I can get it to work, but it's slow updating the colors when toggling.
  3. Speaking of colors, we probably should use the accent colors for the chart itself.
  4. We need more padding around the chart container. It's a bit tight at the moment.

@sconnole
Copy link
Contributor Author

@jbrooksuk Good call on light theme. I forgot to QA that. I have updated the following

  1. removed compiled files
  2. Updated to show labels in light mode
    image
    image
  3. Added tailwind based accent colors for the graph
  4. Adding padding-3 to the chart

@jbrooksuk jbrooksuk merged commit ca321a1 into cachethq:main Feb 24, 2025
24 of 31 checks passed
@jbrooksuk
Copy link
Member

Huge! Thank you so much @sconnole!

@jbrooksuk jbrooksuk mentioned this pull request Feb 24, 2025
@Ionys320
Copy link

Sorry for my no-work at the end, and big thanks @sconnole ❤️

@sconnole
Copy link
Contributor Author

🎉 Glad it's merged in. Thanks @Ionys320 for getting the building block going!

@jbrooksuk
Copy link
Member

Awesome team work 🫶

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants