Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async/stream/future plumbing for wasmtime-environ #10047

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dicej
Copy link
Contributor

@dicej dicej commented Jan 18, 2025

I've split this out of #9582 to make review easier.

This patch includes the plumbing needed to route
async/stream/future/error-context data from wit-parser, through the various layers of wasmtime-environ, and on to wasmtime-cranelift and wasmtime. The wasmtime::runtime, wasmtime_environ::fact, and wasmtime_cranelift::compiler::component modules only contain todo!() stubs to begin with; I'll flesh those out in later PRs.

I've split this out of bytecodealliance#9582 to make review easier.

This patch includes the plumbing needed to route
async/stream/future/error-context data from `wit-parser`, through the various
layers of `wasmtime-environ`, and on to `wasmtime-cranelift` and `wasmtime`.
The `wasmtime::runtime`, `wasmtime_environ::fact`, and
`wasmtime_cranelift::compiler::component` modules only contain `todo!()` stubs
to begin with; I'll flesh those out in later PRs.

Signed-off-by: Joel Dice <[email protected]>
@dicej dicej requested a review from alexcrichton January 18, 2025 00:51
@dicej
Copy link
Contributor Author

dicej commented Jan 18, 2025

@alexcrichton note all the new fields I've added to VMComponentContext/VMComponentOffsets. I dimly recall that you wanted me to switch most or all of them over to libcalls, and that that would involve adding a bunch of new methods to the VMStore trait, but I can't remember the details. Perhaps you could walk me through that next week.

@github-actions github-actions bot added the wasmtime:api Related to the API of the `wasmtime` crate itself label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasmtime:api Related to the API of the `wasmtime` crate itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant