Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using dynamic lib default in linux-x86_64 #155

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

using dynamic lib default in linux-x86_64 #155

wants to merge 1 commit into from

Conversation

rayowang
Copy link

Like wasmer, use dynamic library by default in linux-x86_64 to prevent duplicate symbol. (#150)

@rayowang rayowang mentioned this pull request Oct 31, 2022
Open
@alexcrichton
Copy link
Member

Thanks for the PR, but I'm hesitant to switch the defaults here. How does that work with distribution of the dynamic library itself? Do all users have to specify LD_LIBRARY_PATH as you've done here? That's what makes me think that while this is a good option to have it's not a better default just yet.

@scottopell
Copy link

I believe with shared libraries you do have the additional overhead of managing LD_LIBRARY_PATH or similar. This mentions being inspired by wasmer, and you can see in this wasmer PR that using a dynamic lib can cause some pain in distributing the resulting go binaries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rayowang @alexcrichton @scottopell