added the option for geom_points #146
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jeff, This should be acceptable. The only thing I didn't like is adding tidyquant::theme_tq() here:
Theme_tq is actually recreated in timetk to avoid a circular dependency. Solution is to revert this to the original. Can you do that and re submit the pull request? |
… default point size could be 1
Jeffrothschild
commented
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first pull request, so hopefully I'm going about it the right way. When using plot_anomaly_diagnostics, I found myself wanting to see geom points in there as well because I have some time series data that have inconsistent measurement frequency and it's helpful for me to see the points. It defaults to having them off, but is easy enough to put on.