Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(rust): use localhost constructor for HostnamePort #8737

Merged
merged 1 commit into from
Jan 31, 2025
Merged

refactor(rust): use localhost constructor for HostnamePort #8737

merged 1 commit into from
Jan 31, 2025
+49 −44

Conversation

ilyaaay
Copy link
Contributor

@ilyaaay ilyaaay commented Jan 10, 2025

No description provided.

@ilyaaay ilyaaay requested a review from a team as a code owner January 10, 2025 22:03
@ilyaaay ilyaaay mentioned this pull request Jan 10, 2025
Closed
@adrianbenavides
Copy link
Member

Hey @ilyaaay, thanks for submitting the PR, it looks good!

While we are at it, could you do the same with the StaticHostnamePort struct? We have some constants that would also benefit from this.

Also, you'd need to fix the conflicts with develop. To do so, you have to git rebase develop on your branch.

@adrianbenavides adrianbenavides linked an issue Jan 16, 2025 that may be closed by this pull request
Add HostnamePort::localhost(u16) constructor to HostnamePort #8712
Closed
@ilyaaay ilyaaay force-pushed the ilyaaay/add-localhost-constructor-for-hostname-port branch from b860ad6 to c207225 Compare January 16, 2025 21:13
@ilyaaay
Copy link
Contributor Author

ilyaaay commented Jan 16, 2025

@adrianbenavides I added and used localhost constructor for StaticHostnamePort. Also rebased my branch.

@ilyaaay ilyaaay changed the title chore(rust): add localhost constructor for hostname port refactor(rust): use localhost constructor for HostnamePort Jan 16, 2025
@adrianbenavides adrianbenavides force-pushed the ilyaaay/add-localhost-constructor-for-hostname-port branch from 8fbc557 to 3bb1e6d Compare January 31, 2025 08:03
@adrianbenavides adrianbenavides force-pushed the ilyaaay/add-localhost-constructor-for-hostname-port branch from 3bb1e6d to 2fec2c4 Compare January 31, 2025 08:45
adrianbenavides
adrianbenavides approved these changes Jan 31, 2025
View reviewed changes
Copy link
Member

@adrianbenavides adrianbenavides left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge! 🚀 Thank you so much @ilyaaay for your PR

@adrianbenavides adrianbenavides added this pull request to the merge queue Jan 31, 2025
Merged via the queue into build-trust:develop with commit 3c39d90 Jan 31, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianbenavides adrianbenavides adrianbenavides approved these changes

@etorreborre etorreborre etorreborre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add HostnamePort::localhost(u16) constructor to HostnamePort
3 participants
@ilyaaay @adrianbenavides @etorreborre