Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include VerifiedEmailForPluginPublish feature flag #45

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Include VerifiedEmailForPluginPublish feature flag #45

wants to merge 2 commits into from

Conversation

TChukwuleta
Copy link
Collaborator

Resolves #41

Include VerifiedEmailForPluginPublish feature flag to prevent unverified plugin publish

rockstardev
rockstardev requested changes Nov 29, 2024
View reviewed changes
Copy link
Member

@rockstardev rockstardev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we spoke through DMs, this should be done through Settings table rather than launchSettings.json so we avoid server restarts.

https://github.com/btcpayserver/btcpayserver-plugin-builder/blob/master/PluginBuilder/Data/Scripts/11.SettingsTable.sql

@TChukwuleta
Copy link
Collaborator Author

updated the flow to follow Settings table

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rockstardev rockstardev rockstardev requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@TChukwuleta @rockstardev