fix(ppx): allow type annotations #80
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@glennsl You can just download brisk-reconciler inside a project that use it (like revery) and remove the deps from the packages.json (I'm not sure if mandatory but I do to avoid conflict) and dune will always pick your latest change :) |
glennsl
force-pushed
the
fix/ppx/allow-type-annotation
branch
from
cde5907
to
b5701a3
Compare
glennsl
force-pushed
the
fix/ppx/allow-type-annotation
branch
from
56f92ef
to
29def12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not entirely sure this covers all the cases, and I'm sure it can be implemented more elegantly, but I'm kind of fed up with this now.
esyseem completely broken wrt. local resolutions, which makes it hard to test in real world use cases, and I have no great desire to studyppxlibin great depth as it seems to be going away soon. Suggestions for how to improve it would be more than welcome though.Also, depends on #79. Sorry about the noise.