Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(general): Upgrade cyclonedx version to >=7 <8 #6997

Merged
merged 4 commits into from
Feb 6, 2025

Conversation

emaohi
Copy link
Contributor

@emaohi emaohi commented Feb 5, 2025

User description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

Generated description

Below is a concise technical summary of the changes proposed in this PR:

Updates the cyclonedx-python-lib dependency to allow versions up to 8.0.0. Adds new test files for different CycloneDX schema versions and modifies existing tests to support parameterized testing of multiple schema versions.

TopicDetails
CycloneDX Testing Adds new test files for CycloneDX schema versions 1.0 to 1.4 and modifies existing tests to support parameterized testing of multiple schema versions
Modified files (6)
  • tests/sca_package_2/outputs/results_cyclonedx_1_4.xml
  • tests/sca_package_2/outputs/results_cyclonedx_1_0.xml
  • tests/sca_package_2/outputs/results_cyclonedx_1_2.xml
  • tests/sca_package_2/outputs/results_cyclonedx_1_3.xml
  • tests/sca_package_2/test_output_reports.py
  • tests/sca_package_2/outputs/results_cyclonedx_1_1.xml
Latest Contributors(2)
UserCommitDate
tjwaldfeat-general-initial-s...January 23, 2025
MaryArmalychore-sca-CLI-remove-t...April 14, 2024
Dependency Update Updates the cyclonedx-python-lib dependency version range from <7.0.0,>=6.0.0 to <8.0.0,>=6.0.0 in setup.py and Pipfile.lock
Modified files (3)
  • Pipfile
  • setup.py
  • Pipfile.lock
Latest Contributors(2)
UserCommitDate
tjwaldfeat-general-initial-s...January 23, 2025
tsmithv11chore-secrets-bump-det...December 19, 2024
This pull request is reviewed by Baz. Join @emaohi and the rest of your team on (Baz).

Copy link
Contributor

@omriyoffe-panw omriyoffe-panw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested with >=6.0.0. <8.0.0? Perhaps it may be more safe to not force using newer versions

@emaohi emaohi merged commit 0ddafd3 into main Feb 6, 2025
43 of 44 checks passed
@emaohi emaohi deleted the upgrade-cyclonedx-version branch February 6, 2025 13:48
Saarett pushed a commit that referenced this pull request Feb 6, 2025
* chorse(general): upgrade cyclonedx

* parameterize cyclonedx tests

* allow cyclone from 6 to 8

* change also setup py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants