-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bicep): Add bicep specific for CKV_AZURE_25 since ARM implementation fails #6996
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work and thanks for the contribution! Can you add a test of a Microsoft.Sql/servers
or Microsoft.Sql/servers/databases
without a nested securityAlertPolicies
to make sure it has the desired behavior?
Good point! I'll do that right away |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
…ion fails (#6996) * added test resources for CKV_AZURE_25 * added graph check for CKV_AZURE_25 * added main.bicep test file * added expected file for graph checks * added new tests for CKV_AZURE_25 if no security policy is provided
…ion fails (#6996) * added test resources for CKV_AZURE_25 * added graph check for CKV_AZURE_25 * added main.bicep test file * added expected file for graph checks * added new tests for CKV_AZURE_25 if no security policy is provided
User description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
The change uses the graph to properly check for the 'state' and 'disabledAlerts' attributes in the required securityAlertPolicies for Azure SQL servers and databases. As of now, checkov uses the ARM implementation for this check, which fails for bicep scripts.
Fixes #6963
Checklist:
Generated description
Below is a concise technical summary of the changes proposed in this PR:
Implements a new graph-based check for Azure SQL Server threat detection alerts in Bicep scripts. Adds a YAML configuration file for the check, creates test cases to verify the implementation, and updates the test suite to include the new check. The change addresses an issue where the existing ARM implementation fails for Bicep scripts, ensuring that all threat types are properly enabled for Azure SQL servers and databases.
Modified files (3)
Latest Contributors(2)
Modified files (1)
Latest Contributors(0)