fix(terraform): CKV_AZURE_249 & CKV_AWS_358 - better support for OIDC 'repo' detection regex and conditions order #6994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviadhahami
requested a deployment
to
scan-security
GitHub Actions
Waiting
aviadhahami
changed the title
aviadhahami
changed the title
aviadhahami
changed the title
aviadhahami
changed the title
aviadhahami
changed the title
tsmithv11
approved these changes
Feb 4, 2025
maxamel
approved these changes
Feb 5, 2025
Improved the regex detecting the `repo` claim usage within OIDC configs so it will match GitHub's namings allowance and restrictions. This is a fix for bridgecrewio#6978
Fixed a bug where policies' `condition` blocks order would matter - it does not Fixing bridgecrewio#6986.
aviadhahami
temporarily deployed
to
scan-security
GitHub Actions
Inactive
|
rebased on |
Saarett
pushed a commit
that referenced
this pull request
Feb 5, 2025
… 'repo' detection regex and conditions order (#6994) * FIX(CKV_AZURE_249): better support for OIDC 'repo' detection regex Improved the regex detecting the `repo` claim usage within OIDC configs so it will match GitHub's namings allowance and restrictions. This is a fix for #6978 * FIX(CKV_AWS_358): condition order doesn't matter in OIDC check Fixed a bug where policies' `condition` blocks order would matter - it does not Fixing #6986.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
Description
conditionblocks order would matter - it does not (CKV_AWS_358 is (seemingly unintentionally) enforcing condition ordering in OIDC policies #6986)repoclaim usage within OIDC configs so it will match GitHub's naming allowance and restrictions (CKV_AZURE_249 scan fail for OIDC subject claims analysis for GitHub x Azure on Check on our CI #6978)Fixes
Generated description
Below is a concise technical summary of the changes proposed in this PR:
Enhances OIDC support for GitHub Actions in AWS and Azure. Improves the
gh_repo_regexinoidc_utils.pyto better match GitHub repository naming conventions. Modifies theGithubActionsOIDCTrustPolicycheck in AWS to handle multiple conditions and their order. Updates test files to reflect these changes and adds new test cases for special characters in repo names.oidc_utils.pyto support more complex repository namesModified files (1)
Latest Contributors(1)
GithubActionsOIDCTrustPolicycheck for AWS to handle multiple conditions and their orderModified files (5)
Latest Contributors(2)