feat(general): fix proxy access from git and registry loader #6992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxamel
requested a deployment
to
scan-security
GitHub Actions
Waiting
maxamel
requested a deployment
to
scan-security
GitHub Actions
Waiting
maxamel
requested a deployment
to
scan-security
GitHub Actions
Waiting
maxamel
requested a deployment
to
scan-security
GitHub Actions
Waiting
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
maxamel
requested a deployment
to
scan-security
GitHub Actions
Waiting
maxamel
requested a deployment
to
scan-security
GitHub Actions
Waiting
maxamel
requested a deployment
to
scan-security
GitHub Actions
Waiting
maxamel
requested a deployment
to
scan-security
GitHub Actions
Waiting
maxamel
requested a deployment
to
scan-security
GitHub Actions
Waiting
maxamel
requested a deployment
to
scan-security
GitHub Actions
Waiting
maxamel
requested a deployment
to
scan-security
GitHub Actions
Waiting
maxamel
requested a deployment
to
scan-security
GitHub Actions
Waiting
maxamel
changed the title
maxamel
changed the title
maxamel
requested a deployment
to
scan-security
GitHub Actions
Waiting
omriyoffe-panw
approved these changes
Feb 5, 2025
maxamel
requested a deployment
to
scan-security
GitHub Actions
Waiting
NoaAzoulay
approved these changes
Feb 6, 2025
Saarett
pushed a commit
that referenced
this pull request
Feb 6, 2025
* fix proxy access from git and registry loader * add more logs for visibility * add more prints to debug * replace logs with prints * add more prints * replace env_vars with actual env fetching * add more prints * add more prints * add more prints * add more prints * add print of module_params * fix proxy access * remove unneeded prints * fix lints * remove bad logging * fix logger fields * remove possible sensitive string * fix lint --------- Co-authored-by: Max Amelchenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
This PR intends to fix issues in checkov proxy capabilities. It sets correct proxy attributes for git and tf registry destinations.
Checklist:
Generated description
Below is a concise technical summary of the changes proposed in this PR:
Enhances proxy capabilities for git and registry loaders. Modifies environment variable handling, improves logging, and refactors HTTP requests to support proxy usage. Updates the
ProxyClientclass and adjusts module loading processes in various loaders.Modified files (4)
Latest Contributors(2)
Modified files (5)
Latest Contributors(2)