platform(general): Backfill more eval keys #6970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsmithv11
had a problem deploying
to
scan-security
GitHub Actions
Failure
tsmithv11
had a problem deploying
to
scan-security
GitHub Actions
Failure
tsmithv11
temporarily deployed
to
scan-security
GitHub Actions
Inactive
tsmithv11
temporarily deployed
to
scan-security
GitHub Actions
Inactive
talazuri
approved these changes
Feb 3, 2025
maxamel
approved these changes
Feb 3, 2025
Saarett
pushed a commit
that referenced
this pull request
Feb 3, 2025
* Backfill more eval keys * fix flake8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Adding more eval keys
Generated description
Below is a concise technical summary of the changes proposed in this PR:
Adds the
get_evaluated_keys()method to multiple resource checks in the CloudFormation and ARM modules. This method returns a list of keys that were evaluated during the check, improving the transparency and debuggability of the checks. The changes also include updating thescan_resource_confmethods to set theself.evaluated_keysattribute, which is then used by the newget_evaluated_keys()method.Modified files (74)
Latest Contributors(2)