Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Showing asset type in the text-editor #4605 #4827

Merged
merged 14 commits into from
Mar 13, 2025
Merged

Showing asset type in the text-editor #4605 #4827

merged 14 commits into from
Mar 13, 2025

Conversation

Leksyk
Copy link
Contributor

@Leksyk Leksyk commented Mar 13, 2025 •
edited
Loading

Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

  • Tests pass
  • Appropriate changes to documentation are included in the PR

Leksyk added 14 commits March 7, 2025 19:32
llm-output - rendering text/html in an iframe.
76d4573 
This currently doesn't differenciate between an html piece and an html page.
Depending how trustworthy the source is, the former may be rendered inside the widget.
Merge branch 'main' of github.com:breadboard-ai/breadboard
4ee59c8
Merge branch 'main' of github.com:breadboard-ai/breadboard
7946bc5
Adding mimeType to TemplatePart and filling it when an asset is added.
8f77879
Merge commit '8f77879'
cde67c7
apply comments
cde4ea7
apply comments
2852bca
Merge branch 'asset-mime-types' of github.com:Leksyk/breadboard into …
3807b96 
…asset-mime-types
Merge branch 'main' of github.com:breadboard-ai/breadboard into asset…
6fdf735 
…-mime-types
Merge branch 'main' of github.com:breadboard-ai/breadboard into asset…
189ba4e 
…-mime-types
Fixing Template.preamble rendering with mimeType
09f5e38
Extending fast-access-menu.getMimeType to support storedData and file…
3db84d3 
…Data
Showing asset type in the text-editor breadboard-ai#4605
57e2a54
Merge branch 'main' of github.com:breadboard-ai/breadboard into asset…
86d17e2 
…-mime-types
@Leksyk Leksyk requested a review from dglazkov March 13, 2025 17:33
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2025

⚠️ No Changeset found

Latest commit: 86d17e2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

dglazkov
dglazkov approved these changes Mar 13, 2025
View reviewed changes
Copy link
Collaborator

@dglazkov dglazkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dglazkov dglazkov merged commit 5c0f161 into breadboard-ai:main Mar 13, 2025
2 checks passed
@Leksyk Leksyk deleted the asset-mime-types branch March 18, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dglazkov dglazkov dglazkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Leksyk @dglazkov