Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[board-server] Simplify board creation logic #4789

Merged
merged 7 commits into from
Mar 12, 2025
Merged

Conversation

timswanson-google
Copy link
Member

@timswanson-google timswanson-google commented Mar 12, 2025

Contributes to #4778 by removing special extension logic. If a client uses a name that already exists it will get a 400.

Note that this also gets rid of the "dryRun" request property, which does not appear to be used anywhere. The client does not set this property.

Copy link

changeset-bot bot commented Mar 12, 2025

🦋 Changeset detected

Latest commit: d557b9a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@breadboard-ai/board-server Patch
@breadboard-ai/unified-server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@dglazkov dglazkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timswanson-google timswanson-google merged commit 30685e1 into main Mar 12, 2025
10 checks passed
@timswanson-google timswanson-google deleted the ts-bs-bgl branch March 12, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants