Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rust] bump crates to base64 0.22 #28225

Merged
merged 3 commits into from
Mar 20, 2025
Merged

[rust] bump crates to base64 0.22 #28225

merged 3 commits into from
Mar 20, 2025

Conversation

bridiver
Copy link
Collaborator

@bridiver bridiver commented Mar 19, 2025

Resolves brave/brave-browser#44805

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@bridiver bridiver requested review from a team as code owners March 19, 2025 23:31
@github-actions github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Mar 19, 2025
Copy link
Contributor

[puLL-Merge] - brave/brave-core@28225

Description

This PR updates several Rust dependencies within the Brave Core codebase, primarily upgrading various cryptographic and adblock-related libraries. The main changes include:

  1. Upgrading base64 from v0.13 to v0.22
  2. Upgrading adblock from v0.9.5 to v0.9.6
  3. Upgrading challenge-bypass-ristretto from v2.0.0 to v2.0.2
  4. Updating libsecp256k1 from v0.7.1 to v0.7.2
  5. Updating star-constellation from v0.2.3 to v0.2.5
Changes

Changes

By filename:

components/brave_shields/adblock/rs/Cargo.toml:

  • Updated adblock dependency version to 0.9.6-brave-core

components/challenge_bypass_ristretto/rust/cxx/Cargo.toml:

  • Updated challenge-bypass-ristretto dependency to 2.0.2

components/filecoin/rs/BUILD.gn and Cargo.toml:

  • Switched base64 dependency from v0.13 to v0.22
  • Updated libsecp256k1 to v0.7.2

components/filecoin/rs/src/message.rs and signature.rs:

  • Updated base64 import paths to use new prelude module
  • Updated base64 encoding/decoding calls to use new BASE64_STANDARD constant

components/p3a/constellation/rs/cxx/Cargo.toml:

  • Updated star-constellation dependency to 0.2.5

components/skus/browser/rs/lib/:

  • Updated multiple dependencies including base64 and challenge-bypass-ristretto
  • Modified code to use new base64 prelude and BASE64_STANDARD constant
sequenceDiagram
    participant Developer
    participant Cargo
    participant Dependencies
    participant Code

    Developer->>Cargo: Update dependency versions
    Cargo->>Dependencies: Fetch new versions
    Dependencies-->>Code: Update imports and APIs
    Note over Code: Update base64 usage
    Note over Code: Update crypto library calls
    Code-->>Developer: Apply changes
Loading

@bridiver
Copy link
Collaborator Author

is build failure is due to https://github.com/brave/brave-core/pull/27762/files#r2005693863

@bridiver bridiver merged commit 36cb03f into master Mar 20, 2025
19 of 20 checks passed
@bridiver bridiver deleted the update-base64 branch March 20, 2025 13:53
@github-actions github-actions bot added this to the 1.78.x - Nightly milestone Mar 20, 2025
@brave-builds
Copy link
Collaborator

Released in v1.78.56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) puLL-Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump to base64 0.22
3 participants