Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract locale country code for variations on first run #28096

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

DJAndries
Copy link
Collaborator

@DJAndries DJAndries commented Mar 11, 2025

Resolves brave/brave-browser#44599

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Only test on Windows.

  1. Find or create a study that is country specific and applies to the channel & version being tested.
  2. Set the system locale to match one of the countries in the study.
  3. Install & launch the browser for the first time, access brave://version, ensure study is enabled.
  4. If desired, set the system locale to a country not included in the study, uninstall the browser.
  5. Re-install & launch the browser. Ensure the study is not enabled.

Sorry, something went wrong.

@DJAndries DJAndries requested review from a team as code owners March 11, 2025 22:57
@DJAndries DJAndries force-pushed the griffin-first-run-country branch from 50bc135 to f512396 Compare March 14, 2025 00:13
@DJAndries DJAndries force-pushed the griffin-first-run-country branch from f512396 to 33ba561 Compare March 17, 2025 22:27
@DJAndries DJAndries merged commit 706364a into master Mar 18, 2025
18 checks passed
@DJAndries DJAndries deleted the griffin-first-run-country branch March 18, 2025 03:43
@github-actions github-actions bot added this to the 1.78.x - Nightly milestone Mar 18, 2025
@brave-builds
Copy link
Collaborator

Released in v1.78.49

brave-builds added a commit that referenced this pull request Mar 18, 2025
brave-builds added a commit that referenced this pull request Mar 18, 2025
@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.78.49 Chromium: 134.0.6998.95 (Official Build) nightly (64-bit)
-- | --
Revision | 7edbd46f3dca287cb7238eda27536c9a84a2fea2
OS | Windows 11 Version 24H2 (Build 26100.3194)

Perquisites:

  • ensured that the OS Language is set to the target locale
  • ensure that the OS Region is set to the target locale
  • ensure that you're using a IP address associated with the target locale (Canada/Mexico for this verification/check)

Test Case #1 - CA (Canada)

Example Example Example Example
CanadaDisabled1 CanadaDisabled2 CanadaDisabled3 CanadaDisabled4

Test Case #1 - MX (Mexico)

Example Example Example Example
Mexico1 Mexico2 Mexico3 Mexico4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Country-specific Griffin studies not enabled on first run
4 participants