-
Notifications
You must be signed in to change notification settings - Fork 941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract locale country code for variations on first run #28096
Merged
Merged
+29
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodov
reviewed
Mar 12, 2025
patches/chrome-browser-metrics-chrome_feature_list_creator.cc.patch
Outdated
Show resolved
Hide resolved
50bc135
to
f512396
Compare
goodov
approved these changes
Mar 16, 2025
patches/chrome-browser-metrics-chrome_feature_list_creator.cc.patch
Outdated
Show resolved
Hide resolved
f512396
to
33ba561
Compare
Released in v1.78.49 |
This was referenced Mar 18, 2025
Verification PASSED on
|
Example |
Example |
Example |
Example |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
Test Case #1
- MX
(Mexico)
- downloaded the
Nightly
stub installer via https://brave.com/download-nightly - ensured that
1.78.49 Chromium: 134.0.6998.95
was installed which includes the above change - ensured that
BraveSearchPromotionButtonStudy
wasn't being applied and not visible underbrave://version
- ensured that
BraveSearchPromotionBannerStudy
was being applied and visible underbrave://version
country: ['DE','FR','US','AT','ES','MX','BR','AR','IN
]` as per https://github.com/brave/bravevariations/blob/ee8ab1a3af4a4b8ab41d5d61db89838556e12ab3/studies/BraveSearchPromotionBannerStudy.json5#L62
Example |
Example |
Example |
Example |
---|---|---|---|
![]() |
![]() |
![]() |
![]() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#44599
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Only test on Windows.
brave://version
, ensure study is enabled.