Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow user choose to use TOTP (Time-based one-time password) #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rookiemonkey
Copy link

added support for TOTP instead of just a password but only if their email is confirmed

@rookiemonkey rookiemonkey changed the title let user choose to use TOTP allow user choose to use TOTP (Time-based one-time password) Aug 26, 2020
@kirasiris
Copy link

Hey, this is an incredible feature but remember....Brad usually like to keep the improvements as close as possible to the original course content. @bradtraversy , do you mind checking on this? I believe this is a great feature and surely the students will love it also.

@kirasiris
Copy link

kirasiris commented Dec 24, 2020

, I actually did this about a month ago when Brad released his YouTube video. It would have been good of me to check this PR, I would have had it implemented in my app way long ago lol.

This is my version:
https://gist.github.com/kirasiris/4326bf85d06b78c5e1de9f93c6e05d2a

@rookiemonkey
Copy link
Author

rookiemonkey commented Jan 4, 2021

Hi @kirasiris I'm so sorry for responding so late XD. I'm so focused on my school projects this past days (not to mention celebrating holidays hahah!). I actually thought of it as well that brad might not consider this PR but thats ok because I only requested this PR to practice contributing to open source projects :). I actually had a look on your version and its way more awesome! by the way, Happy New Year! and stay safe always :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants