Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Everytime we instantiate TNSPlayer() it was requesting the audio focus and not abandoning it (until we call
dispose()
which is not always what we want). This is not recommended according to Android documentation and introduces a bug since this is not the expected behaviour.Those issues are facing exactly this bug: nstudio#142 nstudio#137
Android docs states that a well-behaved audio app should manage audio focus according to these general guidelines:
Therefore this pull request strictly obeys Android docs and fix the problem. It does not break existing code, only introduces the expected behaviour. So anyone can update the package and get the expected behaviour. I have also introduced the possibility to pass the durationHint (default is still AUDIOFOCUS_GAIN) to
TNSPlayer
constructor so we can determine differents behaviors by the system and the other application that previously held audio focus. Refer to the updated README.md .Note: This update is only for android player.