♻️ refactor: mailService 내 강결합 제거 #337
Merged
+35
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 이유
회원 가입에 이메일 인증이 필요하나, 기존 이메일 모듈 코드가 사용하기 용이한 형태가 아님에 따른 리팩토링 필요성 대두.
📋 작업 내용
EmailService내 강결합을 제거기존
EmailService내sendMail메소드와createEmail은 RSS 등록 여부 응답 메일을 발송하는 로직과 강하게 결합되어 있습니다.이는 메일 발송이 필요한 다른 기능을 추가 구현하기에 적합하지 않은 형태이기에 메일을 보내는 부분과 RSS 등록 여부 응답 메일을 생성하는 부분을 분리하였습니다.