Fix #76 bugfix restore database with db as argument #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boly38
commented
Apr 20, 2024
| } else { | ||
| command += ' --nsInclude ' + options.db; | ||
| } | ||
| command += ' --nsInclude ' + options.db + '.*'; |
There was a problem hiding this comment.
@dandziz fell free to review this PR (even if already merged, coz I always could improve this)
the bug was here
boly38
commented
Apr 20, 2024
| @@ -59,7 +59,7 @@ describe("MTWrapper unit tests", function () { | |||
|
|
|||
| const command = wrapper.commandConnectFromOptions(mtOptions, '--beginning', true); | |||
|
|
|||
| command.should.be.eql("--beginning --host 127.0.0.1 --port 17017 --username root --password mypass --authenticationDatabase admin --nsInclude myDbForTest"); | |||
| command.should.be.eql("--beginning --host 127.0.0.1 --port 17017 --username root --password mypass --authenticationDatabase admin --nsInclude myDbForTest.*"); | |||
There was a problem hiding this comment.
FYI bugfix related assertion
boly38
commented
Apr 20, 2024
boly38
commented
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #76 bugfix restore database with db as argument
dbname is set,nsIncludeis still reported in the restore command withnsInclude db.*