Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code block after list is wrongly folded into list #10

Open
ericonr opened this issue Aug 4, 2020 · 5 comments
Open

Code block after list is wrongly folded into list #10

ericonr opened this issue Aug 4, 2020 · 5 comments

Comments

@ericonr
Copy link

ericonr commented Aug 4, 2020

Feeding


  • a
b
c

into vmdfmt spits out


  • a b c

Not sure this construct should exist in a proper document, though.

@bobertlo
Copy link
Owner

bobertlo commented Aug 4, 2020

I'll run this through my blackfriday tree dumper and see what we're dealing with here at least.

@bobertlo
Copy link
Owner

bobertlo commented Aug 4, 2020

I have confirmed that this is an upstream issue:

[robert@cygnus ~]$ bfdump test.md
Document
  List
    Item
      Paragraph
        Text "test\n"
        Code: `
a
b
`
        Text ""

The code block should be a different type and on a higher level in the tree.

@ericonr
Copy link
Author

ericonr commented Aug 4, 2020

Oof, would you like me to open an issue for it? Or is it not going to fly since there's blackfriday v2?

@bobertlo
Copy link
Owner

bobertlo commented Aug 4, 2020

You could for their sake but I'm on a 2 year old branch vendoring a patch that breaks tests upstream but fixes a bug for this use case.

For these reasons I am not super interested in 'correctness' bug fixes that are irrelevant to the void-docs downstream. Might look into updating the back end at some point but not at the moment.

@bobertlo
Copy link
Owner

bobertlo commented Aug 4, 2020

I've gotten the impression that, while the v2 generated tree is useful, it is not exactly targetted for general public use lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants