load: accept slt # b-field in 88 mode

bobertlo · Nov 25, 2024 · d458f21 · d458f21
1 parent aadb921
commit d458f21
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/load.go b/load.go
@@ -223,10 +223,12 @@ func getOpModeAndValidate88(Op OpCode, AMode AddressMode, BMode AddressMode) (Op
 
 	case SLT:
 		// SLT;
-		// AB if #A, B otherwise, no #B allowed
-		if BMode == IMMEDIATE {
-			return 0, fmt.Errorf("invalid b mode '#' for op 'slt'")
-		}
+		// AB if #A, B otherwise
+
+		// #B is not allowed by the 88 standard but is allowed on hills
+		// if BMode == IMMEDIATE {
+		// 	return 0, fmt.Errorf("invalid b mode '#' for op 'slt'")
+		// }
 		if AMode == IMMEDIATE {
 			return AB, nil
 		} else {

diff --git a/load_test.go b/load_test.go
@@ -85,6 +85,7 @@ func TestValidInput94(t *testing.T) {
 	// random inputs that are valid but not worth validating output
 	cases := []string{
 		"ADD.BA $ 1, $ 1\n",
+		"SLT $ 0, # 0\n", // not in 88 spec, pMARS supports this though
 	}
 
 	config := ConfigNOP94
@@ -112,7 +113,7 @@ func TestInvalidInput(t *testing.T) {
 		"DAT # 0, $ 0\n",
 		"DAT # 0, @ 0\n",
 		"CMP $ 0, # 0\n",
-		"SLT $ 0, # 0\n",
+		// "SLT $ 0, # 0\n", // pMARS supports this
 		"ADD $ 0, # 0\n",
 		"SUB $ 0, # 0\n",
 		"JMP # 0, $ 0\n",