Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for existing critcmp before cargo install #105

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Check for existing critcmp before cargo install #105

wants to merge 1 commit into from

Conversation

juntyr
Copy link

@juntyr juntyr commented Aug 21, 2023 •
edited
Loading

Fixes #104

@juntyr
Copy link
Author

juntyr commented Aug 21, 2023

Running npx prettier --check . locally runs successfully, since I have prettier v2.8.8 installed, as mentioned in package.json. However, it seems like the CI action does not use the pinned version but installs the latest one, v3.0.2, which finds style issues unrelated to my change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cargo install critcmp installs if install is cached by CI runner
1 participant
@juntyr