-
-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deny warnings and add miri to CI #2448
base: main
Are you sure you want to change the base?
Conversation
Opened #2449 to fix the deprecation warnings. |
Also, I'm not sure if we want to run all tests through MIRI. On my machine (ryzen 5 5600) it takes up to 1hr to run the full test suite. Maybe we should isolate just a couple important tests (JsString, |
It looks like according to |
Really sorry for the wait 😅 We'll probably want to just run the tests for We think it should be better to exclude whole modules from miri runs using |
Hello, I was looking at the good first issue tasks to be able to star collaborating. I found this, almost finished PR? Looks to me like it's only necessary to undo 323eca2 and add |
This Pull Request fixes/closes #2366
It changes the following:
cargo build
Note that this will cause previously passing builds to fail.