-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to v1.7.0 #71
Open
jwijffels
wants to merge
42
commits into
master
Choose a base branch
from
upgrade-v1.7.0-turbowhisper
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat it was - seems ok
… not to need common.cpp
…_diarization_speaker energy_higher_percent is available
add audio_ctx, suppress_regex, temperature, no_timestamps - todo: DTW/grammar remove unused functions (related to parsing command line arguments)
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to
upgrade to whisper.cpp 1.5.5 #64
whisper turbo #67
Latest release #61
to_timestamp: compile common.cpp
timestamp_to_sample: compile common.cpp
replace_all: not needed, removed
whisper_params: changed to the newest version with new params
new params:
audio_ctx = 0
grammar
grammar_rule
grammar_penalty=100
grammar_parsed
temperature=0
temperature_inc=0.2
suppress_regex (regex to suppress tokens)
dtw: "" dynamic time warping
estimate_diarization_speaker: ok, kept as is
whisper_print_progress_callback: ok, keep the old behaviour, nothing changed
whisper_print_segment_callback: ok, keep the old behaviour, nothing changed
WhisperModel: ok, kept as is
whisper_load_model: ok, kept as is
whisper_encode: handled changes internally (but not in the whisper_encode API yet)
audio_ctx = 0
temperature=0
temperature_inc=0.2
suppress_regex (regex to suppress tokens)
Left out changes regarding grammar
grammar
grammar_rule
grammar_penalty=100
grammar_parsed
Not yet included dynamic time warping (dtw)
whisper_print_benchmark: ok, kept as is
whisper_language_info: ok, moved to rcpp_whisper_utils.cpp
Looks ok already, still need to handle all the changes to Makevars