Small tweaks

heyoka/expose_batch_integrators.cpp

@@ -158,8 +158,9 @@ void expose_batch_integrator_impl(py::module_ &m, const std::string &suffix)
 
                     // NOTE: GIL release is fine here even if the events contain
                     // Python objects, as the event vectors are moved in
-                    // upon construction and thus we should never end up calling
-                    // into the interpreter.
+                    // upon construction and thus we never end up calling
+                    // into the interpreter. Also, due to mandatory copy elision,
+                    // we never end up making a copy of the return value.
                     py::gil_scoped_release release;
 
                     return hey::taylor_adaptive_batch<T>{std::move(sys),
@@ -184,8 +185,9 @@ void expose_batch_integrator_impl(py::module_ &m, const std::string &suffix)
 
                     // NOTE: GIL release is fine here even if the events contain
                     // Python objects, as the event vectors are moved in
-                    // upon construction and thus we should never end up calling
-                    // into the interpreter.
+                    // upon construction and thus we never end up calling
+                    // into the interpreter. Also, due to mandatory copy elision,
+                    // we never end up making a copy of the return value.
                     py::gil_scoped_release release;
 
                     return hey::taylor_adaptive_batch<T>{std::move(sys),

heyoka/expose_sgp4_propagators.cpp

@@ -204,6 +204,9 @@ void expose_sgp4_propagator_impl(py::module_ &m, const std::string &suffix)
         "sat_list"_a.noconvert(), "diff_order"_a.noconvert() = static_cast<std::uint32_t>(0),
         HEYOKA_PY_CFUNC_ARGS(false), HEYOKA_PY_LLVM_STATE_ARGS,
         docstrings::sgp4_propagator_init(std::same_as<T, double> ? "float" : "numpy.single").c_str());
+    // NOTE: this should be a static property, but at the moment doing this will mess up
+    // the documentation as sphinx will not pick up the docstring properly. Either we are
+    // doing something wrong in the docstring format or it is a genuine sphinx issue.
     prop_cl.def_property_readonly(
         "jdtype",
         [](const prop_t &) -> py::object {
@@ -291,8 +294,6 @@ void expose_sgp4_propagator_impl(py::module_ &m, const std::string &suffix)
         "__call__",
         [](prop_t &prop, std::variant<py::array_t<T>, py::array_t<date_t>> tm_arr,
            std::optional<py::array_t<T>> out) -> py::array_t<T> {
-            auto np = py::module_::import("numpy");
-
             // NOTE: here we are repeating several checks which are redundant with
             // checks already performed on the C++ side, with the goal of providing better
             // error messages.

heyoka/taylor_expose_integrator.cpp

@@ -123,7 +123,8 @@ void expose_taylor_integrator_impl(py::module &m, const std::string &suffix)
                // NOTE: GIL release is fine here even if the events contain
                // Python objects, as the event vectors are moved in
                // upon construction and thus we should never end up calling
-               // into the interpreter.
+               // into the interpreter. Also, due to mandatory copy elision,
+               // we never end up making a copy of the return value.
                py::gil_scoped_release release;
 
                return std::visit(