Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't run full recovery for snapshot #5031

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

morgando
Copy link
Contributor

Snapshot databases run through all of the logs on startup to populate structures needed for point in time (PIT) snapshots to run correctly. This is overkill, since snapshot databases only actually need to look at the logs written in a fixed time interval. The changes in this PR cause snapshot databases to only run through the logs written in this interval.

riverszhang89
riverszhang89 previously approved these changes Feb 24, 2025
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 21/597 tests failed ⚠.

The first 10 failing tests are:
phys_rep_tiered
phys_rep_tiered_nosource_generated
simple_timepart_reptimeout_generated
simple_timepart
reco-ddlk-sql
commit_delay_on_copy
siasofbounce
simple_ssl
disttxn
phys_rep_tiered_firstfile_generated

markhannum
markhannum previously approved these changes Feb 24, 2025
@morgando morgando dismissed stale reviews from markhannum and riverszhang89 via 0882d11 February 25, 2025 15:58
@morgando morgando force-pushed the snapshot_no_full_rec branch 2 times, most recently from 0882d11 to 27f47cd Compare February 25, 2025 16:01
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 4/597 tests failed ⚠.

The first 10 failing tests are:
phys_rep_tiered
phys_rep_tiered_nosource_generated
phys_rep_tiered_firstfile_generated
incremental_backup_load

@morgando morgando force-pushed the snapshot_no_full_rec branch 5 times, most recently from 2a96ac0 to 4f592c4 Compare February 25, 2025 20:15
@morgando morgando force-pushed the snapshot_no_full_rec branch from 4f592c4 to 75853b1 Compare February 25, 2025 20:26
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 5/597 tests failed ⚠.

The first 10 failing tests are:
phys_rep_tiered
analyze_partial_index_off_generated
phys_rep_tiered_firstfile_generated
phys_rep_tiered_nosource_generated
incremental_backup_load

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants