Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: update GH workflows #29

Merged
merged 5 commits into from
Mar 20, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/linters.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:

steps:
- name: Checkout repository
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Set up Ruby
uses: ruby/setup-ruby@v1
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@ jobs:

strategy:
matrix:
ruby: ['3.0', '3.1', '3.2']
ruby: ['3.0', '3.2']
gemfile: ['rails70_activeadmin']

env:
BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile

steps:
- name: Checkout repository
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Set up Ruby
uses: ruby/setup-ruby@v1
Expand All @@ -33,7 +33,7 @@ jobs:
run: bundle exec rspec --profile

- name: On failure, archive screenshots as artifacts
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
if: failure()
with:
name: test-failed-screenshots
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
name: Specs Rails 6.0
name: Specs Rails 7.1

on:
pull_request:
Expand All @@ -13,15 +13,15 @@ jobs:

strategy:
matrix:
ruby: ['2.7']
gemfile: ['rails60_activeadmin']
ruby: ['3.2', '3.4']
gemfile: ['rails71_activeadmin']

env:
BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile

steps:
- name: Checkout repository
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Set up Ruby
uses: ruby/setup-ruby@v1
Expand All @@ -33,7 +33,7 @@ jobs:
run: bundle exec rspec --profile

- name: On failure, archive screenshots as artifacts
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
if: failure()
with:
name: test-failed-screenshots
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
name: Specs Rails 6.1
name: Specs Rails 7.2

on:
pull_request:
Expand All @@ -13,15 +13,15 @@ jobs:

strategy:
matrix:
ruby: ['2.7', '3.0']
gemfile: ['rails61_activeadmin29', 'rails61_activeadmin']
ruby: ['3.2', '3.4']
gemfile: ['rails72_activeadmin']

env:
BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile

steps:
- name: Checkout repository
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Set up Ruby
uses: ruby/setup-ruby@v1
Expand All @@ -33,7 +33,7 @@ jobs:
run: bundle exec rspec --profile

- name: On failure, archive screenshots as artifacts
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
if: failure()
with:
name: test-failed-screenshots
Expand Down
40 changes: 40 additions & 0 deletions .github/workflows/specs_rails80.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
---
name: Specs Rails 8.0

on:
pull_request:
branches: [master]
push:
branches: [master]

jobs:
test:
runs-on: ubuntu-latest

strategy:
matrix:
ruby: ['3.2', '3.4']
gemfile: ['rails80_activeadmin']

env:
BUNDLE_GEMFILE: ${{ github.workspace }}/gemfiles/${{ matrix.gemfile }}.gemfile

steps:
- name: Checkout repository
uses: actions/checkout@v4

- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: ${{ matrix.ruby }}
bundler-cache: true

- name: Run tests
run: bundle exec rspec --profile

- name: On failure, archive screenshots as artifacts
uses: actions/upload-artifact@v4
if: failure()
with:
name: test-failed-screenshots
path: spec/dummy/tmp/screenshots
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
/.rspec_failures
/.rubocop-*
/Gemfile.lock
/gemfiles/.bundle/config

/_misc/
/spec/dummy/db/*.sqlite3*
Expand Down
37 changes: 29 additions & 8 deletions Appraisals
Original file line number Diff line number Diff line change
@@ -1,25 +1,46 @@
# frozen_string_literal: true

appraise 'rails60-activeadmin' do
gem 'activeadmin'
gem 'rails', '~> 6.0.0'
gem 'selenium-webdriver', require: false
end

appraise 'rails61-activeadmin29' do
gem 'activeadmin', '~> 2.9.0'
gem 'rails', '~> 6.1.0'

gem 'nokogiri', '~> 1.17.2'
gem 'sqlite3', '~> 1.7.0'
end

appraise 'rails61-activeadmin' do
gem 'activeadmin'
gem 'rails', '~> 6.1.0'

gem 'nokogiri', '~> 1.17.2'
gem 'sqlite3', '~> 1.7.0'
end

appraise 'rails70-activeadmin' do
gem 'activeadmin'
gem 'rails', '~> 7.0.0'

# NOTE: workaround for "undefined method `assets' for #<Rails::Application::Configuration:...>"
gem 'sprockets-rails', '~> 3.4.2'
gem 'nokogiri', '~> 1.17.2'
gem 'sqlite3', '~> 1.7.0'
end

appraise 'rails71-activeadmin' do
gem 'activeadmin'
gem 'rails', '~> 7.1.0'

gem 'sqlite3'
end

appraise 'rails72-activeadmin' do
gem 'activeadmin'
gem 'rails', '~> 7.2.0'

gem 'sqlite3'
end

appraise 'rails80-activeadmin' do
gem 'activeadmin'
gem 'rails', '~> 8.0.0'

gem 'sqlite3'
end
40 changes: 20 additions & 20 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,26 +4,26 @@ source 'https://rubygems.org'

gemspec

group :development, :test do
gem 'puma'
gem 'sassc'
gem 'sqlite3'
gem 'bigdecimal'
gem 'mutex_m'
gem 'puma'
gem 'sassc'
gem 'sprockets-rails'

# Testing
gem 'capybara'
gem 'cuprite'
gem 'rspec_junit_formatter'
gem 'rspec-rails'
gem 'rspec-retry'
# Testing
gem 'capybara'
gem 'cuprite'
gem 'rspec_junit_formatter'
gem 'rspec-rails'
gem 'rspec-retry'

# Linters
gem 'fasterer'
gem 'rubocop'
gem 'rubocop-packaging'
gem 'rubocop-performance'
gem 'rubocop-rails'
gem 'rubocop-rspec'
# Linters
gem 'fasterer'
gem 'rubocop'
gem 'rubocop-packaging'
gem 'rubocop-performance'
gem 'rubocop-rails'
gem 'rubocop-rspec'

# Tools
gem 'pry-rails'
end
# Tools
gem 'pry-rails'
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# ActiveAdmin Dynamic Fields
[![gem version](https://badge.fury.io/rb/activeadmin_dynamic_fields.svg)](https://badge.fury.io/rb/activeadmin_dynamic_fields) [![gem downloads](https://badgen.net/rubygems/dt/activeadmin_dynamic_fields)](https://rubygems.org/gems/activeadmin_dynamic_fields) [![linters](https://github.com/blocknotes/activeadmin_dynamic_fields/actions/workflows/linters.yml/badge.svg)](https://github.com/blocknotes/activeadmin_dynamic_fields/actions/workflows/linters.yml) [![specs](https://github.com/blocknotes/activeadmin_dynamic_fields/actions/workflows/specs.yml/badge.svg)](https://github.com/blocknotes/activeadmin_dynamic_fields/actions/workflows/specs.yml)
[![gem version](https://badge.fury.io/rb/activeadmin_dynamic_fields.svg)](https://badge.fury.io/rb/activeadmin_dynamic_fields) [![gem downloads](https://badgen.net/rubygems/dt/activeadmin_dynamic_fields)](https://rubygems.org/gems/activeadmin_dynamic_fields) [![linters](https://github.com/blocknotes/activeadmin_dynamic_fields/actions/workflows/linters.yml/badge.svg)](https://github.com/blocknotes/activeadmin_dynamic_fields/actions/workflows/linters.yml) [![specs](https://github.com/blocknotes/activeadmin_dynamic_fields/actions/workflows/specs_rails70.yml/badge.svg)](https://github.com/blocknotes/activeadmin_dynamic_fields/actions/workflows/specs_rails70.yml)

An Active Admin plugin to add dynamic behaviors to some fields.

Expand Down
2 changes: 1 addition & 1 deletion activeadmin_dynamic_fields.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,5 @@ Gem::Specification.new do |spec|

spec.add_runtime_dependency 'activeadmin', '>= 2.0', '< 4'

spec.add_development_dependency 'appraisal', '~> 2.4'
spec.add_development_dependency 'appraisal', '~> 2.4' # rubocop:disable Gemspec/DevelopmentDependencies
end
27 changes: 0 additions & 27 deletions gemfiles/rails60_activeadmin.gemfile

This file was deleted.

Loading